[PATCH] D109037: [RISCV] Enable shrink wrap by default

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 11:59:13 PDT 2021


evandro added a comment.

In D109037#2975976 <https://reviews.llvm.org/D109037#2975976>, @jrtc27 wrote:

> The change makes sense, surprised this wasn't already the case. Have you done any kind of extensive testing to try and verify there aren't things we're missing that would break shrink wrapping (beyond the bug that motivated the original test case)? That'd really be my only concern.

Yes.  I kept this patch downstream for a couple of weeks or so and several benchmarks and test suites were run with it and not issues came up, even after multiple patches were applied on top of it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109037/new/

https://reviews.llvm.org/D109037



More information about the llvm-commits mailing list