[PATCH] D108357: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 11:53:27 PDT 2021


aemerson added a comment.

In D108357#2969306 <https://reviews.llvm.org/D108357#2969306>, @mbrkusanin wrote:

> Since these combines don't use KnownBitAnalysis or anything similar we can easily use them from legalizer without moving code through CombinerHelper
> Our custom legalization now simply calls CombinerHelper methods.
>
> Opposite is also possible: Move everything to LegalizerHelper and have AArch and Mips instantiate LegalizerHelper. @aemerson, @paquette do you have any objection to doing it that way instead?

You can move the code to the LegalizerHelper and have the combiner call into it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108357/new/

https://reviews.llvm.org/D108357



More information about the llvm-commits mailing list