[PATCH] D109036: [CSSPGO] Sort function offset table to speed up profile loading.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 11:37:14 PDT 2021


wmi accepted this revision.
wmi added a comment.

LGTM.



================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:791
+      for (auto &NameOffset : *OrderedFuncOffsets) {
+        auto &FContext = NameOffset.first;
+        auto FName = FContext.getName();
----------------
can it be a const?


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:792
+        auto &FContext = NameOffset.first;
+        auto FName = FContext.getName();
+        // For function in the current module, keep its farthest ancestor
----------------
const?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109036/new/

https://reviews.llvm.org/D109036



More information about the llvm-commits mailing list