[PATCH] D104662: [SCEVExpander] Prefer pointer expansion for overflow checks
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 1 09:26:45 PDT 2021
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
This LGTM in the name of not introducing `ptrtoint` where it did not exist before.
As @reames pointed out, there are some obvious opportunities to simplify the generated code as a followup. E.g. we usually know the step sign, in which case we can drop half of this code. It would also be nice to get rid of the weird `C - (X - -C)` pattern this generates for `-X`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104662/new/
https://reviews.llvm.org/D104662
More information about the llvm-commits
mailing list