[PATCH] D109063: [SelectionDAG][VP] Fix VP memory ops' EVL/Mask indices

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 09:18:30 PDT 2021


frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:213
 BEGIN_REGISTER_VP_INTRINSIC(vp_store, 2, 3)
-BEGIN_REGISTER_VP_SDNODE(VP_STORE, 0, vp_store, 3, 4)
+BEGIN_REGISTER_VP_SDNODE(VP_STORE, 0, vp_store, 4, 5)
 HANDLE_VP_TO_OPC(Store)
----------------
simoll wrote:
> Could you add a comment here that describes what the SDNode operands are? Same for the others below.
Aye good idea - done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109063/new/

https://reviews.llvm.org/D109063



More information about the llvm-commits mailing list