[PATCH] D107810: [ARM] Improve detection of fallthough when aligning blocks

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 09:12:48 PDT 2021


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:360
     }
-    PrevCanFallthough = MBB.canFallThrough();
+    PrevCanFallthough = is_contained(MBB.successors(), MBB.getNextNode());
   }
----------------
If my understanding is correct then the fall-through branch at the end of `MBB` isn't removed until the LowOverheadLoops pass. Do we therefore need to check if LOL are enabled?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107810/new/

https://reviews.llvm.org/D107810



More information about the llvm-commits mailing list