[PATCH] D109063: [SelectionDAG][VP] Fix VP memory ops' EVL/Mask indices

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

Apart from that LGTM. We don't currently test the SDNode layer directly.. only indirectly through isel



================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:213
 BEGIN_REGISTER_VP_INTRINSIC(vp_store, 2, 3)
-BEGIN_REGISTER_VP_SDNODE(VP_STORE, 0, vp_store, 3, 4)
+BEGIN_REGISTER_VP_SDNODE(VP_STORE, 0, vp_store, 4, 5)
 HANDLE_VP_TO_OPC(Store)
----------------
Could you add a comment here that describes what the SDNode operands are? Same for the others below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109063/new/

https://reviews.llvm.org/D109063