[PATCH] D109049: [SLP] Support llvm.isnan in vectorizer

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 05:47:15 PDT 2021


xbolva00 added a comment.

In D109049#2976566 <https://reviews.llvm.org/D109049#2976566>, @sepavloff wrote:

> In D109049#2976514 <https://reviews.llvm.org/D109049#2976514>, @lebedev.ri wrote:
>
>> In D109049#2976512 <https://reviews.llvm.org/D109049#2976512>, @sepavloff wrote:
>>
>>> In D109049#2976449 <https://reviews.llvm.org/D109049#2976449>, @xbolva00 wrote:
>>>
>>>> But there are concerns in https://reviews.llvm.org/D104854 whether the base change should not be reverted at all…
>>>
>>> There is a discussion: https://lists.llvm.org/pipermail/llvm-dev/2021-August/152257.html, devoted to this topic. There are no additional feedback during the last week, so I would think the problem is closed.
>>
>> Au contraire.
>> It looks like goalpost shifting to me.
>> What is going on the is basic design disscussion, with no clear favorite,
>> even though a design has already been "selected" and committed.
>> I would like to once again urge you to restart this process.
>
> What exactly do you want me to restart? There is already a discussion on this topic, it could be continued. You could express your concerns there to warm the discussion.

Revert original patch while there is a ongoing discussion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109049/new/

https://reviews.llvm.org/D109049



More information about the llvm-commits mailing list