[PATCH] D108200: [llvm][sve] Lowering for VLS masked extending loads
David Truby via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 1 05:44:29 PDT 2021
DavidTruby added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-masked-loads.ll:509
+ %b = load <32 x i16>, <32 x i16>* %bp
+ %ae = zext <32 x i8> %a to <32 x i16>
+ %mask = icmp eq <32 x i16> %ae, %b
----------------
paulwalker-arm wrote:
> Is this necessary? As in, why not just change `%ap` to have the same types as `%bp`.
>
> As an extension to this, once `%a` is a `<32 x i16>` do you need `%b`? I ask because the computation of `%mask` could be `%mask = icmp eq <32 x i16> %a, zeroinitializer`. This latter point probably goes for the whole file to be honest.
%ap needs to have the type <32 x i8> for us to test the masked extending load a few lines later; otherwise we're just performing a normal masked load which is already covered by other tests in this file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108200/new/
https://reviews.llvm.org/D108200
More information about the llvm-commits
mailing list