[PATCH] D107421: [yaml2obj][XCOFF] Customize the string table.

[Esme Yi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/XCOFFYAML.h:63-68
+  uint32_t TableSize = 0; // The actual size of the string table, including the
+                          // size of the length field.
+  uint32_t Length = 0; // The value of the length field for the first 4 bytes of
+                       // the table.
+  std::vector<StringRef> Strings;
+  yaml::BinaryRef RawContent;
----------------
jhenderson wrote:
> These fields probably all want to be Optional values. You need to be able to distinguish the cases where a field has a value of zero/is an empty array/is an empty string from where the field is missing. This is often important for the error case handling, if nothing else.
Yes, agreed. It looks like some fields in other structs need such change as well, maybe we need a new patch to do this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107421/new/

https://reviews.llvm.org/D107421