[PATCH] D109049: [SLP] Support llvm.isnan in vectorizer

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon requested changes to this revision.
RKSimon added a comment.
This revision now requires changes to proceed.

In D109049#2976449 <https://reviews.llvm.org/D109049#2976449>, @xbolva00 wrote:

> But there are concerns in https://reviews.llvm.org/D104854 whether the base change should not be reverted at all…

This needs to be addressed first, I regret putting these isnan cost/vectorization tests/bugs in at all atm as I hadn't realised there were still so many open questions about these new fpclassify intrinsics......



================
Comment at: llvm/include/llvm/IR/Intrinsics.h:192
     ArgKind getArgumentKind() const {
-      assert(Kind == Argument || Kind == ExtendArgument ||
-             Kind == TruncArgument || Kind == HalfVecArgument ||
-             Kind == SameVecWidthArgument || Kind == PtrToArgument ||
-             Kind == VecElementArgument || Kind == Subdivide2Argument ||
-             Kind == Subdivide4Argument || Kind == VecOfBitcastsToInt);
+      assert(hasBoundType() && Kind != VecOfAnyPtrsToElt);
       return (ArgKind)(Argument_Info & 7);
----------------
The creation of hasBoundType and the refactor of these asserts could be pulled out as a preliminary NFC - independent of this patch. Since you are updating the asserts we should add assert messages as well so that they match the style guidelines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109049/new/

https://reviews.llvm.org/D109049