[PATCH] D108890: Document LLVM_ENABLE_RUNTIMES

[Raul Tambre via Phabricator via llvm-commits]

tambre added inline comments.


================
Comment at: llvm/docs/CMake.rst:481
+**LLVM_ENABLE_RUNTIMES**:STRING
+  Build libc++, libc++abi or other projects using that a just-built compiler.
+  This is the correct way to build libc++ when putting together a toolchain.
----------------
This sentence doesn't make much sense.


================
Comment at: llvm/docs/CMake.rst:485
+  correct dependency ordering.
+  Note: the list should not have duplicates with `LLVM_ENABLE_PROJECTS`.
+  The full list is:
----------------
Probably worth wording more strongly and without it being a sidenote.


================
Comment at: llvm/docs/CMake.rst:486
+  Note: the list should not have duplicates with `LLVM_ENABLE_PROJECTS`.
+  The full list is:
+  ``compiler-rt;libc;libcxx;libcxxabi;libunwind;openmp``
----------------
The full list of what? Not the defaults, so probably worth explicitly clarifying that these are possible values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108890/new/

https://reviews.llvm.org/D108890