[PATCH] D109041: [ARM] Fix assembly in `tInt_eh_sjlj_longjmp`

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 00:36:45 PDT 2021


mstorsjo added a reviewer: efriedma.
mstorsjo added a comment.

When uploading diffs, please make the diffs with extra context (e.g. `git diff -U999`).



================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb.td:1548
 let isBarrier = 1, hasSideEffects = 1, isTerminator = 1, isCodeGenOnly = 1,
-    Defs = [ R7, LR, SP ] in
+    Defs = [ R7, R11, LR, SP ] in
 def tInt_eh_sjlj_longjmp : XI<(outs), (ins tGPR:$src, tGPR:$scratch),
----------------
This change looks good and seems to have been requested (and missed by me) in D38253, but we should do the same for `Int_eh_sjlj_longjmp` in ARMInstrInfo.td too - can you amend the patch to change that too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109041/new/

https://reviews.llvm.org/D109041



More information about the llvm-commits mailing list