[PATCH] D109036: [CSSPGO] Sort function offset table to speed up profile loading.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 23:11:58 PDT 2021


wenlei added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfWriter.cpp:176
+  if (FunctionSamples::ProfileIsCS) {
+    // Sort the contexts before writing them out.
+    std::map<SampleContext, uint64_t> OrderedFuncOffsetTable(
----------------
In the comment here, it would be good to point out the need for sorting due to how importing works in prelink. Basically part of the comment from readFuncProfiles. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109036/new/

https://reviews.llvm.org/D109036



More information about the llvm-commits mailing list