[PATCH] D109036: [CSSPGO] Sort function offset table to speed up profile loading.

Tue Aug 31 22:39:36 PDT 2021

wenlei added inline comments.

================
Comment at: llvm/lib/ProfileData/SampleProfWriter.cpp:44

+static cl::opt<bool> SortFuncOffsetTable(
+    "sort-func-offsets", cl::Hidden, cl::init(true),
----------------
hoy wrote:
> wenlei wrote:
> > Why do we need a flag? Can we simplify this by always order the function offset table for CSSPGO profile? 
> This is mostly for debugging and verification of the unordered path that is kept for being compatible with legacy unordered profiles.
I don't think we have a backward-compatibility issue, there's no need to keep the legacy unordered profile. Can we remove it? Testing just need to make sure this ordering change does not affecting importing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109036/new/

https://reviews.llvm.org/D109036