[PATCH] D108973: [SLP][RISCV] Implement unsigned getMinVectorRegisterBitWidth() for RISCV

Luke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 21:32:35 PDT 2021


luke957 added a comment.

In D108973#2974682 <https://reviews.llvm.org/D108973#2974682>, @craig.topper wrote:

> Tests?

Em, I haven't got a proper test case for this. Without this methed being implemented, the mothed in super class will be called and got a return value of 128.

In D108973#2974808 <https://reviews.llvm.org/D108973#2974808>, @craig.topper wrote:

> Is this function just picking the minimum size of vector SLP will use? Do we want that to follow getRegisterBitWidth() or should it be allowed to be lower?

Oh, I get your point. For RVV, we can use a vector registor fractionally, so minimum size of vector could be less than MinVectorRegisterBitWidth. But I'm not sure whether it is appropriate for a methed naming `getMinVectorRegisterBitWidth`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108973/new/

https://reviews.llvm.org/D108973



More information about the llvm-commits mailing list