[PATCH] D109037: [RISCV] Enable shrink wrap by default

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 18:04:55 PDT 2021


jrtc27 added a comment.

The change makes sense, surprised this wasn't already the case. Have you done any kind of extensive testing to try and verify there aren't things we're missing that would break shrink wrapping (beyond the bug that motivated the original test case)? That'd really be my only concern.



================
Comment at: llvm/test/CodeGen/RISCV/shrinkwrap.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc -mtriple riscv32 < %s | FileCheck %s -check-prefix=RV32I-NOSW
-; RUN: llc -mtriple riscv32 -enable-shrink-wrap < %s | FileCheck %s -check-prefix=RV32I-SW
----------------
Is there value in keeping an -enable-shrink-wrap=false case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109037/new/

https://reviews.llvm.org/D109037



More information about the llvm-commits mailing list