[PATCH] D109032: [AMDGPU][NFC] Alter ComplexPattern types to be consistent with their uses

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I'm not sure where this is going without the context of the other patch.

I think iPTR is a flawed concept that doesn't work without the address space. AMDGPU does not want the type changing magic of iPTR when there are mixed and constant pointer sizes that never change, so the fixed types are more logical.



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1320-1322
+def DS1Addr1Offset : ComplexPattern<iPTR, 2, "SelectDS1Addr1Offset">;
+def DS64Bit4ByteAligned : ComplexPattern<iPTR, 3, "SelectDS64Bit4ByteAligned">;
+def DS128Bit8ByteAligned : ComplexPattern<iPTR, 3, "SelectDS128Bit8ByteAligned">;
----------------
I think iPTR is a flawed concept that doesn't work without the address space, so I don't think AMDGPU should ever use it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109032/new/

https://reviews.llvm.org/D109032