[PATCH] D109030: [LLD][COFF] Clean paths in PDB even when /pdbsourcepath isn't used

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 16:10:05 PDT 2021


amccarth added a comment.

I'm mildly surprised the `make_absolute` call doesn't remove unnecessary dotted paths.  I guess that's related to the weird schism between `sys::fs` and `sys::path`.

Having recently tried out `std::filesystem`, I was pleasantly surprised that it was not nearly as terrible as I expected.  :-)   I know it doesn't meet the cross platform needs of LLVM, but maybe we should consider making LLVM's path handling more like it at some point...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109030/new/

https://reviews.llvm.org/D109030



More information about the llvm-commits mailing list