[PATCH] D107874: [DWARF] Find offset of attribute.

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo marked 3 inline comments as done.
ayermolo added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:1788
+    uint64_t OffsetVal =
+        it->getAttributeOffsetFromIndex(*AttrIndex, /* offset */ 0, *U);
+    EXPECT_TRUE(
----------------
dblaikie wrote:
> Could probably also test the AttrIndex value before using it to lookup the attribute value.
Not sure I follow. I am testing it on line 1786.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107874/new/

https://reviews.llvm.org/D107874