[PATCH] D108850: [LLD] Remove global state in lldCommon

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Thanks!

Regarding performance, yes, the memory mapped I/O makes measurement very noisy. I'm not worried about this change regressing performance.



================
Comment at: lld/include/lld/Common/Globals.h:30
+struct TimerState;
+class CommonGlobals final {
+public:
----------------
I feel like the LLVM-y naming convention for this would be to use the word Context somehow. Either `Link(|ing|er)Context`, `LldContext`, `LldContextBase`. I could imagine inheriting the COFF context from the linker context, or something like that.

I don't like bikeshedding, but I also feel like the best time to get the name right is at the beginning.

See also the prior art of `MachOLinkingContext` in the old MachO linker.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108850/new/

https://reviews.llvm.org/D108850