[PATCH] D106990: [IROutliner] Outlining branches with single entry and single exit

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 15:05:24 PDT 2021


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

I think this looks fine with nits.



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:36
 
+extern cl::opt<bool> DisableBranches;
+
----------------
this could use a comment?


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:803
+    for (BasicBlock *Succ : successors(Block)) {
+      if (!BBSet.contains(Succ)) {
+        Exits.insert(Succ);
----------------
drop braces?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106990/new/

https://reviews.llvm.org/D106990



More information about the llvm-commits mailing list