[PATCH] D106989: [IRSim] Finding Branch Similarity
Andrew Litteken via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 31 15:03:11 PDT 2021
AndrewLitteken added inline comments.
================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:65
+ : Inst(I), Legal(Legality), IDL(&IDList) {
+ if (I)
+ initializeInstruction();
----------------
paquette wrote:
> Why would `I` ever be null?
I changed things up so that at the end of a function, there is a nullptr used for the instruction of the IRInstructionData so that the end of the list can be detected rather than having to use the isKnownSentinel code from before.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106989/new/
https://reviews.llvm.org/D106989
More information about the llvm-commits
mailing list