[PATCH] D108657: [CodeExtractor] Ensuring ordering of exitStub creation

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 14:53:08 PDT 2021


paquette added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:1292
     for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i)
       if (!Blocks.count(TI->getSuccessor(i))) {
         BasicBlock *OldTarget = TI->getSuccessor(i);
----------------
Reduce indentation?

```
 if (Blocks.count(TI->getSuccessor(i)))
   continue;
...
```


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:1657
+    for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i)
+      if (!Blocks.count(TI->getSuccessor(i))) {
+        BasicBlock *OldTarget = TI->getSuccessor(i);
----------------
reduce indentation here too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108657/new/

https://reviews.llvm.org/D108657



More information about the llvm-commits mailing list