[PATCH] D109016: [llvm-objdump] Fix 'llvm-objdump -dr' for executables with relocations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 14:36:53 PDT 2021


MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/exec-relocations.test:54
+      - Offset:          0x400590
+        Symbol:          'puts@@GLIBC'
+        Type:            R_X86_64_PLT32
----------------
Use just `puts`

Versioned symbols are not encoded this way.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/exec-relocations.test:57
+        Addend:          -4
+  - Type:            SectionHeaderTable
+    Sections:
----------------
This is not needed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109016/new/

https://reviews.llvm.org/D109016



More information about the llvm-commits mailing list