[PATCH] D109018: [llvm-ar][nfc] Reword help message to be less ambiguous on what p and t do.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 12:57:33 PDT 2021


oontvoo created this revision.
oontvoo added a reviewer: MaskRay.
Herald added a subscriber: rupprecht.
oontvoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The current help msg isn't super clear on whether t prints the content of the files or just the list of files.
(I'd certainly thought it'd print the list of files, and accidentally had a bunch of "gargabe" printed to my terminal).
Similarly, t sounded like it'd do what p actually did.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109018

Files:
  llvm/tools/llvm-ar/llvm-ar.cpp


Index: llvm/tools/llvm-ar/llvm-ar.cpp
===================================================================
--- llvm/tools/llvm-ar/llvm-ar.cpp
+++ llvm/tools/llvm-ar/llvm-ar.cpp
@@ -96,11 +96,11 @@
 OPERATIONS:
   d - delete [files] from the archive
   m - move [files] in the archive
-  p - print [files] found in the archive
+  p - print contents of [files] found in the archive
   q - quick append [files] to the archive
   r - replace or insert [files] into the archive
   s - act as ranlib
-  t - display contents of archive
+  t - display list of files in archive
   x - extract [files] from the archive
 
 MODIFIERS:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109018.369768.patch
Type: text/x-patch
Size: 622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210831/45edc05e/attachment.bin>


More information about the llvm-commits mailing list