[llvm] a26b09c - [CMake] Remove unneeded -Wdelete-non-virtual-dtor availability check
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 31 11:19:09 PDT 2021
Author: Fangrui Song
Date: 2021-08-31T11:19:04-07:00
New Revision: a26b09cb982753d1ce3b086341ba9e9c585bb5e6
URL: https://github.com/llvm/llvm-project/commit/a26b09cb982753d1ce3b086341ba9e9c585bb5e6
DIFF: https://github.com/llvm/llvm-project/commit/a26b09cb982753d1ce3b086341ba9e9c585bb5e6.diff
LOG: [CMake] Remove unneeded -Wdelete-non-virtual-dtor availability check
Available and good in Clang 3.5/GCC 5.
Added:
Modified:
llvm/cmake/modules/HandleLLVMOptions.cmake
Removed:
################################################################################
diff --git a/llvm/cmake/modules/HandleLLVMOptions.cmake b/llvm/cmake/modules/HandleLLVMOptions.cmake
index c12440d502b7..af7dee903e6d 100644
--- a/llvm/cmake/modules/HandleLLVMOptions.cmake
+++ b/llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -736,10 +736,8 @@ if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))
check_cxx_compiler_flag("-Wnoexcept-type" CXX_SUPPORTS_NOEXCEPT_TYPE_FLAG)
append_if(CXX_SUPPORTS_NOEXCEPT_TYPE_FLAG "-Wno-noexcept-type" CMAKE_CXX_FLAGS)
- append("-Wnon-virtual-dtor" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
-
- # Enable -Wdelete-non-virtual-dtor if available.
- add_flag_if_supported("-Wdelete-non-virtual-dtor" DELETE_NON_VIRTUAL_DTOR_FLAG)
+ append("-Wnon-virtual-dtor" CMAKE_CXX_FLAGS)
+ append("-Wdelete-non-virtual-dtor" CMAKE_CXX_FLAGS)
# Enable -Wsuggest-override if it's available, and only if it doesn't
# suggest adding 'override' to functions that are already marked 'final'
More information about the llvm-commits
mailing list