[PATCH] D108521: [runtime] Move prolog/epilog block to a post-simplify strategy

[Anna Thomas via Phabricator via llvm-commits]

anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp:949
+  // For unroll factor 2 remainder loop will have 1 iteration.
+  if (Count == 2 && DT && LI && SE) {
+    // TODO: This code could probably be pulled out into a helper function
----------------
reames wrote:
> anna wrote:
> > Could you move this code above the `EXPENSIVE CHECKS` since there is DT updates here?
> > We can have full verification of `DT` in that case.
> I'm happy to duplicate the expensive check if desired, but having it after manual DT update, and before well tested utilities which assume an up to date DT on entry makes sense to me.  
ah got it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108521/new/

https://reviews.llvm.org/D108521