[PATCH] D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked an inline comment as done.
DiggerLin added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-visibility.ll:76
+; XCOFF32-NEXT:     Section: N_UNDEF
+; XCOFF32-NEXT:     Type: 0x2000
+; XCOFF32-NEXT:     StorageClass: C_EXT (0x2)
----------------
hubert.reinterpretcast wrote:
> Generating visibility in XCOFF32 requires the auxiliary header. The test needs to check the auxiliary header. @DiggerLin, @jasonliu, fya.
1. do we want to generate old 32bits xcoff object file format? if we only want to generate the  new 32bits xcoff object file and 64 bit xcoff object file.  we  can use new 32bits  and 64 bits xcoff's  interpret to generate the n_type here and and set the o_vstamp field to 2 when we generate the auxiliary header later

2. for decode symbol table entry , the n_type , if we want to  decode the old 32 bits xcoff object file. we need to parse the o_vstamp of auxiliary header first and interpret the n_type based on the value of  o_vstamp .

@hubert.reinterpretcast 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84265/new/

https://reviews.llvm.org/D84265