[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 31 07:15:46 PDT 2021
frasercrmck added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101
+ } else {
+ RVVBitsMin = RVVVectorBitsMinOpt;
+ RVVBitsMax = RVVVectorBitsMaxOpt;
----------------
craig.topper wrote:
> If clang always emits the attribute, are these options effectively dead for clang codegen?
Yes, that's a good point - I'd missed that. I'm not sure the best way of keeping that ability apart from moving the options up to clang and dealing with the fallout from that. Which I'm not even sure we //can// deal with yet?
Unless we make the options override the attribute, though that might be its own can of worms.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107290/new/
https://reviews.llvm.org/D107290
More information about the llvm-commits
mailing list