[PATCH] D108993: [SVE] Fix the FP arithmetic instruction costs for SVE

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 06:32:38 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1449
 
+    // These nodes are marked as 'custom' so we can lower to the predicated
+    // form, but we know that they are legal.
----------------
This condition is missing `!Ty->getScalarType()->isFP128Ty()`, and if you add it, the if-statement can be merged with the one above:

  ..
  case ISD::FNEG:
    if (!Ty->getScalarType()->isFP128Ty())
      return (Cost + 2) * LT.first;
  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108993/new/

https://reviews.llvm.org/D108993



More information about the llvm-commits mailing list