[PATCH] D108703: [SLP]No need to schedule/check parent for extract{element/value} instruction.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 05:22:40 PDT 2021


ABataev added a comment.

In D108703#2974428 <https://reviews.llvm.org/D108703#2974428>, @anton-afanasyev wrote:

>> Looks like it crashes on shuffles, just need to add a check for shuffles in assert.
>
> No, it crashes on `extractelement` with non-constant index. I've commented this inline.
> The current crash could just be fixed by removing one assert check, but I've found several more minors, so may be it worth to revert? I think this should be recommited with negative tests for `extractelement` as wel as for `insertelement` (are we able to schedule `insertelement` with non-constant index now?)

Could you revert the patch and I'll fix it once I'm back from vacation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108703/new/

https://reviews.llvm.org/D108703



More information about the llvm-commits mailing list