[PATCH] D108136: [LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction patterns

[David Sherwood via Phabricator via llvm-commits]

david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9243
+      if (RecurrenceDescriptor::isMinMaxRecurrenceKind(Kind) ||
+          RecurrenceDescriptor::isSelectCmpRecurrenceKind)
         RecipeBuilder.recordRecipeOf(cast<Instruction>(R->getOperand(0)));
----------------
xbolva00 wrote:
> RecurrenceDescriptor::isSelectCmpRecurrenceKind(Kind)) {
> 
> + any test for this code path?
Good spot @xbolva00! The extra checks I added were never being hit because we never create reduction recipes for this new recurrence kind. I've added some asserts instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108136/new/

https://reviews.llvm.org/D108136