[PATCH] D108971: [AMDGPU] Split entry basic block after alloca instructions.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 31 01:12:30 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUReplaceLDSUseWithPointer.cpp:196
+    //
+    // Find the split point just after alloca.
+    auto &EBB = K->getEntryBlock();
----------------
Wouldn't this break if the entry block contains something that needs the lds pointer initialized, followed by an alloca?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108971/new/

https://reviews.llvm.org/D108971



More information about the llvm-commits mailing list