[PATCH] D108968: [DIArgList] Re-unique after changing operands to fix non-determinism

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 30 22:18:49 PDT 2021


MaskRay added a comment.

[Thanks! Worth cherry picking this into release/13.x so that distcc/icecc/etc users can benefit ]



================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1660
+  if (Uniq) {
+    auto *Uniqued = uniquify();
+    if (Uniqued != this)
----------------
only used once, so perhaps just `if (uniquify() != this)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108968/new/

https://reviews.llvm.org/D108968



More information about the llvm-commits mailing list