[PATCH] D104662: [SCEVExpander] Prefer pointer expansion for overflow checks

Mon Aug 30 22:09:50 PDT 2021

mkazantsev added a comment.

In D104662#2871330 <https://reviews.llvm.org/D104662#2871330>, @reames wrote:

> In D104662#2832601 <https://reviews.llvm.org/D104662#2832601>, @mkazantsev wrote:
>
>> I don't think that increase of loop size may be justified by the fact that InstCombine will later clean it up. Loop passes may go in one loop pipeline, and passes like unswitch may be pessimized by this.
>
> This comment doesn't make sense to me.  What increase in loop size are you referring to?   This change adjusts the type used for a generate test, nothing more.

I was looking at code changes. Maybe it's ok,but formally it's an increase that will pessimize unswitching etc. Do we have reasons to think it will be later undone by other transforms, or will cause no harm?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104662/new/

https://reviews.llvm.org/D104662