[PATCH] D108943: Fine grain control over some symbol visibility

Mon Aug 30 20:46:40 PDT 2021

rnk added a comment.

In D108943#2973580 <https://reviews.llvm.org/D108943#2973580>, @MaskRay wrote:

> With this patch, what exact configurations are now working? Can you show the relevant cflags/ldflags and/or downstream usage?

Previously the failures were described here:
https://reviews.llvm.org/D101972#2746842
Pointed to this task:
https://cbs.centos.org/koji/taskinfo?taskID=2483905
Extracting the cmake command line from the log produces:
https://reviews.llvm.org/P8273

The interesting part is probably just ` -DLLVM_BUILD_LLVM_DYLIB:BOOL=ON -DLLVM_LINK_LLVM_DYLIB:BOOL=ON`, and that it causes some IRTests unit tests to fail (such as `IR/./IRTests/CGSCCCallbacksTest.InstrumentedInvalidatingPasses`). I haven't replicated this personally.

Presumably what is happening is that `llvm::Any::TypeId<llvm::Function>::Id` receives hidden visibility, so the typeids of such objects do not compare equal when they are passed between the LLVM DSO and the gtest shell test executable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108943/new/

https://reviews.llvm.org/D108943