[PATCH] D108437: [CSSPGO] split context string III - llvm-profgen changes

Mon Aug 30 18:56:05 PDT 2021

hoy added inline comments.

================
Comment at: llvm/test/tools/llvm-profgen/recursion-compression-pseudoprobe.test:12
+
+; CHECK-UNCOMPRESS: [main:2 @ foo:5 @ fa:8 @ fa:7 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:6 @ fa]:4:1
 ; CHECK-UNCOMPRESS:  1: 1
----------------
wenlei wrote:
> hoy wrote:
> > wenlei wrote:
> > > This order change is due to sortFuncProfiles change in D108435? Does the test change belong to this MD5 patch or D108435? 
> > The order change is due to the flip of using `>` to `<` for `sortFuncProfiles` in D108433, so that we don't have to provide a `>` operator.
> I was asking why this test change is here since the sortFuncProfiles is in the 2nd patch. But if you're going to commit these three patches together, it's not going to make a difference anyways. 
Oh yeah, I'll commit all patches as a whole. Will update the original patch before checking them in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108437/new/

https://reviews.llvm.org/D108437