[PATCH] D108437: [CSSPGO] split context string III - llvm-profgen changes

Mon Aug 30 18:24:47 PDT 2021

wenlei accepted this revision.
wenlei added a comment.

lgtm, thanks.

================
Comment at: llvm/test/tools/llvm-profgen/recursion-compression-pseudoprobe.test:12
+
+; CHECK-UNCOMPRESS: [main:2 @ foo:5 @ fa:8 @ fa:7 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:5 @ fb:6 @ fa]:4:1
 ; CHECK-UNCOMPRESS:  1: 1
----------------
This order change is due to sortFuncProfiles change in D108435? Does the test change belong to this MD5 patch or D108435? 

================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:374
+        getCallerContext(CalleeContext.getContextFrames(), CallerContextId);
+    SampleContextFrames CallerContextRef(CallerContextId);

----------------
wenlei wrote:
> The name CallerContextRef probably is left over from before we renamed into SampleContextFrames. Rename CallerContextRef accordingly, same for other places. And all other places where Context is called Name better be renamed accordingly too.
getFunctionProfileForLeafProbe has two instance of ContextRef still.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108437/new/

https://reviews.llvm.org/D108437