[PATCH] D106989: [IRSim] Finding Branch Similarity

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:187
 
+  if (isa<BranchInst>(A.Inst) && isa<BranchInst>(B.Inst) &&
+      A.RelativeBlockLocations.size() != B.RelativeBlockLocations.size())
----------------
paquette wrote:
> De Morgan + return this value?
Since it's possible this function will have more instruction types added to it, that may remain true, and for clarity I feel like it's better to keep it as is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106989/new/

https://reviews.llvm.org/D106989