[PATCH] D106990: [IROutliner] Outlining branches with single entry and single exit

Andrew Litteken via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 30 14:01:11 PDT 2021


AndrewLitteken added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:817
+  for (BasicBlock *Block : BE) {
+    for (BasicBlock *Succ : successors(Block)) {
+      if (!BBSet.contains(Succ)) {
----------------
paquette wrote:
> this loop could be an `any_of`?
I don't think so? We need to look at all of the successors, and for each one not contained in, it needs to get added to the set. So we need a boolean for each block so I think this makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106990/new/

https://reviews.llvm.org/D106990



More information about the llvm-commits mailing list