[PATCH] D108342: [CSSPGO] Enable loading MD5 CS profile.

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 30 13:39:57 PDT 2021


wlei added a comment.

In D108342#2973176 <https://reviews.llvm.org/D108342#2973176>, @hoy wrote:

> In D108342#2971668 <https://reviews.llvm.org/D108342#2971668>, @wenlei wrote:
>
>>> The work on llvm-profgen side is not included. Currently I'm relying on llvm-profdata to get a md5 cs profile.
>>
>> Is there blocker for this to be done in llvm-profgen? I imagine if llvm-profdata can generate md5 cs profile, llvm-profgen should be no different by reusing the writer to handle this?
>
> Yes, that's the way we were using previously. There is an optimization we can do before it comes to the writer for pseudo probe. Pseudo probe comes with GUID so we can use that inside in the profile generator and unwinder. I think @wlei had a change for that which we can land separately.

Yes, it's in https://reviews.llvm.org/D107779 (TODO: change the writer to convert MD5 back to std::string), I can continue with it when we check in this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108342/new/

https://reviews.llvm.org/D108342



More information about the llvm-commits mailing list