[PATCH] D108835: [NVPTX] consider nvptx-nvidia-gpulibs triple to be compatible with other variants.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 30 12:08:51 PDT 2021


jdoerfert added a comment.

In D108835#2972612 <https://reviews.llvm.org/D108835#2972612>, @tra wrote:

> How is `libomptarget-nvptx-sm_80.bc` built? Perhaps it should be changed to use a more detailed triple. Perhaps match libdevice's `nvptx64-nvidia-gpulibs` or have a distinct openmp-specific one?
>
> Do we have to deal with the libomptarget-nvptx-sm_80.bc shipped with the current `nvptx64` triple or is it shipped with clang and we don't need to worry about the older versions in the wild?

We do not have to care about older versions and we can change the triple there. I'm not sure changing it to gpulibs is the right thing though.
My plan was to normalize `nvptx64` to `nvptx-nvidia-cuda` in the frontend such that user can use any subset of that normalized triple w/o warning.
Unsure what we gain by having "gpulibs" and special handling there. That said we could certainly do it.

I'm however unsure how that helps us with libdevice, libomptarget-nvptx is in our control so certainly less of a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108835/new/

https://reviews.llvm.org/D108835



More information about the llvm-commits mailing list