[PATCH] D108298: [NPM] Print '-passes' compatible string for built pipeline.

[Markus Lavin via Phabricator via llvm-commits]

markus added inline comments.


================
Comment at: llvm/include/llvm/IR/PassManager.h:1319
+                std::function<StringRef(StringRef)> MapClassName2PassName) {
+    OS << "invalidate<all>";
+  }
----------------
aeubanks wrote:
> does this not work with the default logic?
Apparently it does since `PassRegistry.def` contains 
```
 MODULE_PASS("invalidate<all>", InvalidateAllAnalysesPass())
```
So the implementation in `PassInfoMixin` handles it.
But this is different from the other `invalidate<>` though so IMHO it seems a bit nicer to be more explicit about it as there is a specific `InvalidateAllAnalysesPass` struct for it.


================
Comment at: llvm/include/llvm/IR/PassManagerInternal.h:98
+
+  void printPipelineParams(raw_ostream &OS) override {
+    Pass.printPipelineParams(OS);
----------------
aeubanks wrote:
> can this be part of `printPipeline`?
I don't think so. It needs to be separate so that it can be overridden separately in the Pass classes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108298/new/

https://reviews.llvm.org/D108298