[PATCH] D108837: [SimplifyCFG] Ignore free instructions when computing cost for folding branch to common dest

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 30 11:40:12 PDT 2021


aeubanks added a comment.

In D108837#2972812 <https://reviews.llvm.org/D108837#2972812>, @aeubanks wrote:

> In D108837#2970575 <https://reviews.llvm.org/D108837#2970575>, @Prazek wrote:
>
>> This looks resonable. BTW are `{launder,strip}.inariant.group` intrinsics considered to be free now?  I remember fixing this in InlineCost, but this seems to be other cost heuristic.  They totally should be considered free.
>
> https://github.com/llvm/llvm-project/blob/83df94067d367d91dcc37e269a3d7317ebe97bb4/llvm/include/llvm/Analysis/TargetTransformInfoImpl.h#L588

Looks like you added this in https://reviews.llvm.org/D51814 :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108837/new/

https://reviews.llvm.org/D108837



More information about the llvm-commits mailing list