[PATCH] D105733: [OpaquePtr] Require matching signature in getCalledFunction()

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

@dexonsmith I personally don't think it's worth the churn. We can split the users of getCalledFunction() into three categories: 1. Those that explicitly require that explicitly require a signature match (https://github.com/llvm/llvm-project/blob/0529e2e01888129b21becd1fe3a61d9cb07c6fcd/llvm/lib/Target/AMDGPU/AMDGPUFixFunctionBitcasts.cpp#L36 is the most pure example of that), 2. Those that don't care because InstCombine canonicalizes away bitcasts and 3. Those where it may be relevant for phase ordering reasons. I expect that group 2 is by far the largest, and group 3 is rather small, which means that there would be little practical benefit to doing this work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105733/new/

https://reviews.llvm.org/D105733