[PATCH] D108772: [LSR] Make sure that Factor fits into Base type

[Danila Malyutin via Phabricator via llvm-commits]

danilaml updated this revision to Diff 369459.
danilaml added a comment.

Addressed Anna's suggestions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108772/new/

https://reviews.llvm.org/D108772

Files:
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
  llvm/test/Transforms/LoopStrengthReduce/pr42770.ll


Index: llvm/test/Transforms/LoopStrengthReduce/pr42770.ll
===================================================================
--- llvm/test/Transforms/LoopStrengthReduce/pr42770.ll
+++ llvm/test/Transforms/LoopStrengthReduce/pr42770.ll
@@ -1,6 +1,5 @@
 ; Check that it doesn't crash
 ; REQUIRES: asserts
-; XFAIL: *
 ; RUN: opt < %s -loop-reduce -S
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128-ni:1"
Index: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
+++ llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
@@ -3934,6 +3934,9 @@
 
   // Check each interesting stride.
   for (int64_t Factor : Factors) {
+    // Check that Factor can be represented by IntTy
+    if (!ConstantInt::isValueValidForType(IntTy, Factor))
+      continue;
     // Check that the multiplication doesn't overflow.
     if (Base.BaseOffset == std::numeric_limits<int64_t>::min() && Factor == -1)
       continue;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108772.369459.patch
Type: text/x-patch
Size: 1031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210830/b52ecb89/attachment.bin>