[PATCH] D105284: Greedy set cover implementation of `Merger::Merge`

Aristotelis Koutsouridis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 30 06:35:18 PDT 2021


arisKoutsou updated this revision to Diff 369438.
arisKoutsou added a comment.



- Add comments for argument names when passing argument values.
- Change `AllFeatures`. Calculate all unique features by considering `Feature % kFeatureSetSize` as the feature value.
- Change `continue` to `break` statement in main loop. Add assertions to highlight the condition that exits the loop.
- Remove checking for feature-less files since we are not removing features from any `MergeFileInfo` objects.
- Update tests, add testcase for feature collision on the bitvector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105284/new/

https://reviews.llvm.org/D105284

Files:
  compiler-rt/lib/fuzzer/FuzzerDriver.cpp
  compiler-rt/lib/fuzzer/FuzzerFlags.def
  compiler-rt/lib/fuzzer/FuzzerFork.cpp
  compiler-rt/lib/fuzzer/FuzzerInternal.h
  compiler-rt/lib/fuzzer/FuzzerMerge.cpp
  compiler-rt/lib/fuzzer/FuzzerMerge.h
  compiler-rt/lib/fuzzer/tests/FuzzerUnittest.cpp
  compiler-rt/test/fuzzer/set_cover_merge.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105284.369438.patch
Type: text/x-patch
Size: 22452 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210830/d8d5c5fd/attachment.bin>


More information about the llvm-commits mailing list