[PATCH] D106947: [DSE][NFC] Rename Later->Killing, Earlier->Killed

Mon Aug 30 03:45:31 PDT 2021

ebrevnov added a comment.

In D106947#2953538 <https://reviews.llvm.org/D106947#2953538>, @asbirlea wrote:

> Thank you for doing this cleanup!
> I agree the new names are more descriptive, but my feedback is that the code becomes very hard to read. I for one have a hard time following where in the code it says `Killing` and where `Killed` after the refactoring.
> May I suggest using `Killing` and `Dead` (or variations of `PotentiallyDead`/`MaybeDead` etc)? Happy to hear other suggestions of names that have different "root" not just different declension.
> Disclaimer: I'm not a native speaker either, just giving some thoughts  :-).

"Killing" and "Dead" looks OK for me. "Maybe" prefix already reserved for Optional values in the code. If there are no other suggestions in next few days I will go with this variant. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106947/new/

https://reviews.llvm.org/D106947