[PATCH] D108690: Explicit approach to controlling symbol visibility

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 27 03:46:37 PDT 2021


jrtc27 added a comment.

Is there a strategy for downstreams so that we don't have a weird mishmash of symbol visibilities, where files we've added have the old rules applied but files present upstream have the new rules? I don't particularly want to be trawling through both our modified backends trying to find every .h and .cpp file we've added, and people with complete out-of-tree backends will have even more of a hard time.



================
Comment at: llvm/lib/Target/AArch64/AArch64.h:96
 void initializeAArch64StackTaggingPreRAPass(PassRegistry&);
-} // end namespace llvm
+} // namespace LLVM_LIBRARY_VISIBILITY
 
----------------
This has lost the actual namespace name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108690/new/

https://reviews.llvm.org/D108690



More information about the llvm-commits mailing list